Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support RegularExpression for path matching #10717

Merged
merged 2 commits into from
May 23, 2024
Merged

Support RegularExpression for path matching #10717

merged 2 commits into from
May 23, 2024

Conversation

dmavrommatis
Copy link
Contributor

What does this PR do?

Pull request introduced support for path matching of type RegularExpression from Gateway API.

Motivation

Moving from traefik/IngressRoute to gateway/HttpRoute is not possible since we are using a lot of PathRegexp which is not yet supported.

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

@traefiker traefiker added this to the 3.0 milestone May 13, 2024
@kevinpollet
Copy link
Member

Hello @dmavrommatis and thanks for your contribution,

As this is an enhancement, please could you rebase this pull request on master?

@ldez ldez removed this from the 3.0 milestone May 14, 2024
@dmavrommatis dmavrommatis changed the base branch from v3.0 to master May 14, 2024 11:10
@dmavrommatis dmavrommatis force-pushed the add-httproute-regex-pathmatch branch from c41e48a to 8245755 Compare May 14, 2024 11:13
@dmavrommatis
Copy link
Contributor Author

Hello @dmavrommatis and thanks for your contribution,

As this is an enhancement, please could you rebase this pull request on master?

Changed the target branch to master and rebased. Previously I chose v3.0 branch because of the PR guide advising to use the v3.0 branch for enchancements.

Enhancements:
- for Traefik v2: we only accept bug fixes
- for Traefik v3: use branch v3.0

@ldez ldez added this to the next milestone May 14, 2024
@rtribotte rtribotte self-assigned this May 16, 2024
@kevinpollet kevinpollet self-assigned this May 16, 2024
@kevinpollet kevinpollet force-pushed the add-httproute-regex-pathmatch branch from 8245755 to 749930d Compare May 23, 2024 15:03
kevinpollet
kevinpollet approved these changes May 23, 2024
View reviewed changes
Copy link
Member

@kevinpollet kevinpollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

rtribotte
rtribotte approved these changes May 23, 2024
View reviewed changes
Copy link
Member

@rtribotte rtribotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

lbenguigui
lbenguigui approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@lbenguigui lbenguigui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevinpollet kevinpollet removed their assignment May 23, 2024
@traefiker traefiker merged commit 6e61fe0 into traefik:master May 23, 2024
23 checks passed
@dmavrommatis dmavrommatis deleted the add-httproute-regex-pathmatch branch May 24, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinpollet kevinpollet kevinpollet approved these changes

@rtribotte rtribotte rtribotte approved these changes

@lbenguigui lbenguigui lbenguigui approved these changes

Assignees
No one assigned
Labels
area/provider/k8s/gatewayapi kind/enhancement a new or improved feature. size/S
Projects
None yet
Milestone
next
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@dmavrommatis @kevinpollet @rtribotte @lbenguigui @ldez @traefiker